gh-118647: Add defaults to typing.Generator and typing.AsyncGenerator#118648
gh-118647: Add defaults to typing.Generator and typing.AsyncGenerator#118648JelleZijlstra merged 4 commits intopython:mainfrom
Conversation
|
It might be worth considering also updating But we can also save it for a follow-up PR, if you'd prefer that. A change in typeshed doesn't make sense until we test 3.13 to the CI. |
|
@Daverball Possibly, but note that we're one day away from the feature freeze for Python 3.13. I can spend some time on it later today, but please open a separate issue first. @AlexWaygood if you have time, could you review this PR that just adds defaults for Generator and AsyncGenerator? |
|
|
Co-authored-by: Alex Waygood <[email protected]>
I would hope this isn't a real blocker here. From a user standpoint, users are told
(https://docs.python.org/3/library/typing.html#typing.Generator) If this deprecation results in them not being equivalent anymore, you've broken the documented idea of them being equivalent. |
Co-authored-by: Nikita Sobolev <[email protected]>
…erator (python#118648) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: Nikita Sobolev <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--118648.org.readthedocs.build/